Skip to content

Properly Hash create_files #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Properly Hash create_files #883

merged 2 commits into from
Jul 21, 2025

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl requested a review from Paul-Ferrell July 17, 2025 22:24
@hwikle-lanl hwikle-lanl self-assigned this Jul 17, 2025
@hwikle-lanl hwikle-lanl added the bug Something isn't working label Jul 17, 2025
@hwikle-lanl hwikle-lanl linked an issue Jul 17, 2025 that may be closed by this pull request
Changes to create_files do not trigger a rebuild #881
Closed
@hwikle-lanl hwikle-lanl marked this pull request as ready for review July 17, 2025 22:26
Paul-Ferrell
Paul-Ferrell previously approved these changes Jul 17, 2025
View reviewed changes
@Paul-Ferrell Paul-Ferrell merged commit 7e79c8b into develop Jul 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Ferrell Paul-Ferrell Paul-Ferrell approved these changes

Assignees

@hwikle-lanl hwikle-lanl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to create_files do not trigger a rebuild
2 participants
@hwikle-lanl @Paul-Ferrell