fix(cmd_parse): command parsing on arm machines #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This benchmark will always exit through the
print_usage
in the default switch case on ARM machines.rma-mt/src/rmamt_options.c
Lines 234 to 236 in d09c4d0
As the
getlong_opt
returns an int and c is defined aschar
rma-mt/src/rmamt_options.c
Line 109 in d09c4d0
rma-mt/src/rmamt_options.c
Line 79 in d09c4d0
On
x86
this is not an issue but onarm
this can never exit as -1 will be converted into 255 and it end up in the default switch statement.This PR fixes
fixing command parsing as some compiler do not auto correct the -1 to a char type
also I needed to use ./configure LIBS="-lpthread" to make it compile
More infos
Compiler Explorer
I think
cmp
on armyields different flags than the `cmp on x86