Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary flag bits #732

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Remove unnecessary flag bits #732

merged 4 commits into from
Jan 31, 2024

Conversation

keskitalo
Copy link
Member

Resolve a conflict in default shared flag bits by removing unnecessary flag masks

@keskitalo keskitalo requested a review from tskisner January 30, 2024 23:00
tskisner
tskisner approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for solving the mask bit conflict!

@keskitalo keskitalo merged commit 1e139bd into toast3 Jan 31, 2024
6 checks passed
@keskitalo keskitalo deleted the remove_unnecessary_flag_bits branch January 31, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keskitalo @tskisner