Improve checks of azimuth range for atmosphere simulation #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update operator names and inputs * try to infer weather from schedule if not provided
|
Can you confirm that you are able to simulate atmosphere with this fix? |
|
Yes, at least I tried the same script that gave me the error before and the atmosphere simulation finished without errors. |
|
Excellent. I've started the CI tests and will merge once they complete. Thanks a lot for the rapid turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Standardize' the az/el range checks against the simulated range in order to not raise unjustified errors.
Also, update the toast_sim_ground_simple workflow.