Add a new, general purpose convolution function #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places throughout the code we perform Fourier domain convolution and use a variety of techniques. This work aims to have a common function for some of these use cases which carefully handles the symmetric extension of data in the Fourier domain buffer and is unit tested. Changes include: - New toast.fft.convolve function that can take precomputed kernels or use a callback function to generate the kernels. Unit tests that verify roundtrip and expected sample phase shift introduced by a Butterworth filter. - Porting of the timeconstant deconvolution operator to this new function. - Small unrelated fix to toast timing plots - Unrelated fixes to DetectorData indexing. In a couple places we were triggering data copying by using numpy "advanced indexing".
|
Some diagnostic plots from the unit tests: Input fake data with 2 sine waves: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places throughout the code we perform Fourier domain convolution and use a variety of techniques. This work aims to have a common function for some of these use cases which carefully handles the symmetric extension of data in the Fourier domain buffer and is unit tested. Changes include:
New toast.fft.convolve function that can take precomputed kernels or use a callback function to generate the kernels. Unit tests verify roundtrip and expected sample phase shift introduced by a Butterworth filter.
Porting of the timeconstant deconvolution operator to this new function.
Small unrelated fix to toast timing plots
Unrelated fixes to DetectorData indexing. In a couple places we were triggering data copying by using numpy "advanced indexing".