-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-29742 Fix problem with eclcc when filename is not an valid identifier #17479
base: candidate-9.2.x
Are you sure you want to change the base?
Conversation
…ifier * Treat the ecl file in the same way as submitting from stdin, or any other file that is not part of a repository Signed-off-by: Gavin Halliday <[email protected]>
https://track.hpccsystems.com/browse/HPCC-29742 |
@GordonSmith what is your opinion on this, and whether the change is ok. It means that if you submit a query from a directory that is part of your include path then they cannot access the symbol $. That actually affects some of out regression tests -
That suggests the change isn't a good idea. |
@@ -1078,13 +1081,18 @@ static bool findFilenameInSearchPath(StringBuffer & attributePath, const char * | |||
tail++; | |||
if (convertPathToModule(attributePath, tail)) | |||
return true; | |||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug unrelated to this issue: Line 1080-1081 should really be:
if (isPathSepChar(*tail))
tail++
else if (*tail!=nullptr)
break; // to avoid matching part of the filename in expandedSourceName
Type of change:
Checklist:
Smoketest:
Testing: