HPCC-28073 Additional service calls to be added to Dali Admin #17627
Conversation
|
https://track.hpccsystems.com/browse/HPCC-28073 |
|
@jeclrsg and @GordonSmith DaliImport and DaliCount seem to be giving me a bit of trouble, please review. |
There was a problem hiding this comment.
@kunalaswani Added a couple comments that I think might be related to the problems you were having w/ the Count and Import components. Also, the Ping one could be deleted I think.
kunalaswani
force-pushed
the
HPCC-28073
branch
2 times, most recently
from
42b13a4
to
9dfaa23
Compare
kunalaswani
force-pushed
the
HPCC-28073
branch
2 times, most recently
from
73e92a6
to
30b46c8
Compare
| message: nlsHPCC.DaliPromptConfirm, | ||
| onSubmit: React.useCallback(() => { | ||
| myDaliService.Import({ XML: xml, Path: path, Add: add }).then(response => { | ||
| const data = csvParse(response.Result); |
There was a problem hiding this comment.
I am curious why the csvParse() is used in DaliImport and DaliDelete and the parser.parse() is used for DaliAdd and DaliCount. In DaliCount, the response.Result is an integer. In DaliAdd/DaliDelete/DaliImport, the response.Result is a string.
There was a problem hiding this comment.
For DaliCount using csvparse causes an error where WsDali.CountResponse.Result: number but WsDali.CountRequest.Path?: string... which is why we are using the parser.parse().
DaliAdd was switched back to csvParse, that was an error.
| const [columns, setColumns] = React.useState<IColumn[]>([]); | ||
| const [items, setItems] = React.useState<any[]>([]); | ||
| const [path, setPath] = React.useState<string>(""); | ||
| const [value, DaliAdd] = React.useState<string>(""); |
There was a problem hiding this comment.
missed this earlier, but "DaliAdd" here should be "setValue"
|
|
||
| const onSubmit = React.useCallback(() => { | ||
| myDaliService.Count({ Path: path }).then(response => { | ||
| const data = parser.parse(response.Result); |
There was a problem hiding this comment.
The import for parser doesn't seem to be correct. The only similar import I could find is import * as parser from "dojox/xml/parser"; (eg, https://github.com/hpcc-systems/HPCC-Platform/blob/master/esp/src/src/ESPGraph.ts#L4 and a few other places). But I don't think that's what you want either, since response.Result is a number, rather than something to be parsed, as you and Kevin were discussing.
I think you'd need to define data and columns as arrays containing one item. Maybe something like:
const data = [{
key: "Result",
result: response.Result
}];
const columns = [{
key: "Result",
name: "Result",
fieldName: "result",
minWidth: 100
}];
https://developer.microsoft.com/en-us/fluentui#/controls/web/detailslist
Add and Delete functionality and some additional read functions added to Dali Admin UI. Signed-off-by: Kunal Aswani <[email protected]>
Add and Delete functionality and some additional read functions added to Dali Admin UI.
Type of change:
Checklist:
Smoketest:
Testing: