-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32424 ECL Watch v9 Source Files default sorting #19016
HPCC-32424 ECL Watch v9 Source Files default sorting #19016
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32424 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
changes the default sorting of files listed on the Source Files tab of the Workunit Details page, such that subfiles immediately follow their respective superfiles Signed-off-by: Jeremy Clements <[email protected]>
17785c9
to
3924908
Compare
sortedFiles.push(...relatedChildren); | ||
}); | ||
|
||
return sortedFiles; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking something more like:
files.sort((a, b)=>{
const retVal = a.__hpcc_parentName.localeCompare(b.__hpcc_parentName);
if (retVal ===0) {
return a.Name.localeCompare(b.Name);
}
return retVal;
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to work the same; children don't immediately follow their parents with this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the raw data, or on the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't being sorted correctly in the data, so it wasn't either on the page
9699f43
into
hpcc-systems:candidate-9.2.x
changes the default sorting of files listed on the Source Files tab of the Workunit Details page, such that subfiles immediately follow their respective superfiles
Type of change:
Checklist:
Smoketest:
Testing: