feat: Add lit-html enabled graph #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
force-pushed
the
LIT_GRAPH
branch
from
d9f5bbc to
726a087
Compare
jeclrsg
reviewed
Jan 23, 2025
There was a problem hiding this comment.
@GordonSmith Didn't notice anything except those test failures that GH pointed out
| @@ -76,9 +76,9 @@ export class Graph2 extends GraphReactT<ISubgraph, IVertex, IEdge> { | |||
| this._centroidFilter.update(this.centroidColor()); | |||
| } | |||
| } | |||
| Graph2.prototype._class += " graph_Graph2"; | |||
| GraphReact.prototype._class += " graph_React"; | |||
There was a problem hiding this comment.
Should this be graph_GraphReact? Github Actions is noting some test failures below.
|
|
||
| constructor(subgraphRenderer: Component<SG>, vertexRenderer: Component<V>, edgeRenderer: Component<E>) { | ||
| super(adapter(subgraphRenderer), adapter(vertexRenderer), adapter(edgeRenderer)); | ||
| } |
There was a problem hiding this comment.
And is the other test failure because there isn't a render function in here?
GordonSmith
force-pushed
the
LIT_GRAPH
branch
from
9488d23 to
3e1d0be
Compare
jeclrsg
reviewed
Jan 28, 2025
There was a problem hiding this comment.
@GordonSmith The only thing that jumped out at me were a couple of urls in one of the tests. I assumed they were icon images, they just looked weird (some kind of Thai language subdomain of bing.com?)
| ["a", "[email protected]", "fa-at", false, false, false, "fa-plus", "https://th.bing.com/th/id/OIP.3FhSHq5xMXMDZ7gYBZ1nzQHaHa?w=210&h=210&c=7&r=0&o=5&pid=1.7"], | ||
| [1, "Napoleon", "fa-user-o", true, true, true, "fa-plus", "https://th.bing.com/th/id/OIP.3FhSHq5xMXMDZ7gYBZ1nzQHaHa?w=210&h=210&c=7&r=0&o=5&pid=1.7"], |
GordonSmith
force-pushed
the
LIT_GRAPH
branch
3 times, most recently
from
daa3081 to
bac0657
Compare
Signed-off-by: Gordon Smith <[email protected]> WIP
GordonSmith
force-pushed
the
LIT_GRAPH
branch
from
cd53708 to
8dec33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: