Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comms): map Kind ints to strings in normalizeDetails #4348

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix(comms): map Kind ints to strings in normalizeDetails #4348

merged 1 commit into from
Feb 20, 2025

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Feb 19, 2025

while looping through the properties of each scope, if the "Kind" property exists, assign the "Formatted" property the corresponding value from WUDetailsMetaResponse

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@jeclrsg
fix(comms): map Kind ints to strings in normalizeDetails
ea2e769 
while looping through the properties of each scope, if the "Kind"
property exists, assign the "Formatted" property the corresponding
value from WUDetailsMetaResponse

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg requested a review from GordonSmith February 19, 2025 17:35
@GordonSmith GordonSmith merged commit 5605dbb into hpcc-systems:trunk Feb 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith