feat: Add llama.cpp web assembly support #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
commented
Aug 28, 2024
GordonSmith
force-pushed
the
LLAMA_II
branch
2 times, most recently
from
ccd0c36
to
1e3330a
Compare
jeclrsg
reviewed
Aug 28, 2024
There was a problem hiding this comment.
@GordonSmith only one question about the test file. The version test seems to perform the exact same thing twice?
Comment on lines
+20
to
+25
| llama = await Llama.load(); | ||
| v = llama.version(); | ||
| expect(v).to.be.a.string; | ||
| expect(v).to.be.not.empty; | ||
| expect(v).equals(v1); | ||
| Llama.unload(); |
There was a problem hiding this comment.
Is this supposed to perform the same test twice?
There was a problem hiding this comment.
Yes - its testing the unload and reload capabilities.
jeclrsg
approved these changes
Aug 29, 2024
Primarily for calculating embeddings on the client Signed-off-by: Gordon Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily for calculating embeddings on the client