Skip to content

Commit

Permalink
HPCC4J-641 DFSClient test suite dataset fix
Browse files Browse the repository at this point in the history
- Fixed issue with DFSClient test suite using incorrect datasets
- Removed XML dataset from tests

Signed-off-by: James McMullan [email protected]
  • Loading branch information
jpmcmu committed Sep 11, 2024
1 parent bd73e85 commit 51ed0ef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
public class DFSReadWriteTest extends BaseRemoteTest
{
private static final String[] datasets = { "~benchmark::integer::20kb", "~unit_test::all_types::thor", "~unit_test::all_types::xml", "~unit_test::all_types::json", "~unit_test::all_types::csv" };
private static final int[] expectedCounts = { 1250, 10000, 10000, 10000, 10000, 10000};
// Note: These datasets are generated by dfsclient/src/target/resources/generate-datasets.ecl
private static final String[] datasets = { "~benchmark::integer::20kb", "~unit_test::all_types::thor", "~unit_test::all_types::json", "~unit_test::all_types::csv" };
private static final int[] expectedCounts = { 1250, 100000, 100000, 100000};
private static final Version newProtocolVersion = new Version(8,12,10);


Expand Down
2 changes: 1 addition & 1 deletion dfsclient/src/test/resources/generate-datasets.ecl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ IMPORT Std;

unique_keys := 100000; // Should be less than number of records
unique_values := 10212; // Should be less than number of records
totalrecs1 := 10000;
totalrecs1 := 100000;

childRec := {STRING8 childField1, INTEGER8 childField2, REAL8 childField3};

Expand Down

0 comments on commit 51ed0ef

Please sign in to comment.