Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-529 DFSClient: BinaryRecordWriter NPE with null UTF8 strings #629

Merged
merged 1 commit into from
Aug 10, 2023
Merged

HPCC4J-529 DFSClient: BinaryRecordWriter NPE with null UTF8 strings #629

merged 1 commit into from
Aug 10, 2023

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Aug 9, 2023

  • Fixed BinaryRecordWriter pathways to check for null elements
  • Added a new null element test

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu
DFSClient: BinaryRecordWriter NPE with null UTF8 strings
2c28d71 
- Fixed BinaryRecordWriter pathways to check for null elements
- Added a new null element test

Signed-off-by: James McMullan [email protected]
rpastrana
rpastrana reviewed Aug 9, 2023
View reviewed changes
dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSReadWriteTest.java
HPCCRecord record = new HPCCRecord(fields, recordDef);
records.add(record);
}
writeFile(records, "null::element::test", recordDef, connTO);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does HPCC represent the Nulled records/fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, question it doesn't. So, before writing we are capturing and converting null values to a default / empty value.

rpastrana
rpastrana approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu approved

@rpastrana rpastrana merged commit 69444f3 into hpcc-systems:candidate-9.2.x Aug 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

@drealeed drealeed Awaiting requested review from drealeed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana