Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japi 524 ws fileio ws fs regressions #632

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Japi 524 ws fileio ws fs regressions #632

merged 2 commits into from
Aug 18, 2023

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Aug 17, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@rpastrana rpastrana changed the base branch from candidate-9.0.x to candidate-9.2.x August 17, 2023 15:35
@rpastrana rpastrana force-pushed the JAPI-524-WsFILEIO-WsFSRegressions branch 2 times, most recently from 7788cb0 to 89b0721 Compare August 17, 2023 16:45
@rpastrana
Copy link
Member Author

HPCC30117 status: 'open'
Fetching isTargetHPCCContainerized...
Warning: Tests run: 6, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 0.305 s - in org.hpccsystems.ws.client.WSFileIOClientTest
[INFO] Running org.hpccsystems.ws.client.WSWorkunitsTest
wuid: W20230817-172226
Fetching isTargetHPCCContainerized...

@rpastrana rpastrana force-pushed the JAPI-524-WsFILEIO-WsFSRegressions branch 2 times, most recently from 9be82bc to a17b1f6 Compare August 17, 2023 18:05
@rpastrana rpastrana requested a review from jpmcmu August 17, 2023 18:05
@rpastrana
Copy link
Member Author

@jpmcmu please review.

jpmcmu
jpmcmu approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana Only one comment, but otherwise looks good.

.github/workflows/httpsUnitTests.yml Outdated
run: mvn -B --activate-profiles jenkins-on-demand -Dmaven.gpg.skip=true -Dmaven.javadoc.skip=true -Dmaven.test.failure.ignore=false -Dhpccconn=https://eclwatch.default:8010 -Dwssqlconn=https://sql2ecl.default:8510 -DHPCC30117=open install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on creating a github variable to inject maven options here? I don't think it is critical to take that approach, but it seems like it could be useful.

@rpastrana
JAPI-524 Address wsfileio/wsfs junit failures
160afbd 
- Ignores invalid fileio tests until HPCC_30117 is addressed
- WsFS conditionally provides DZ path and name if available
- Adds CUSTOM_MVN_OPTIONS env var as mvn command arg

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the JAPI-524-WsFILEIO-WsFSRegressions branch 6 times, most recently from 9a7f0d7 to b8d2e16 Compare August 18, 2023 15:57
@rpastrana
JAPI-524 env var test
ee846bd 
Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the JAPI-524-WsFILEIO-WsFSRegressions branch from b8d2e16 to ee846bd Compare August 18, 2023 16:10
@rpastrana rpastrana merged commit fac3791 into hpcc-systems:candidate-9.2.x Aug 18, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu