Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-553 Github Actions: Add baremetal test workflow #669

Merged
merged 2 commits into from
Jan 19, 2024
Merged

HPCC4J-553 Github Actions: Add baremetal test workflow #669

merged 2 commits into from
Jan 19, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jan 8, 2024 •
edited
Loading

  • Renamed existing k8s workflow
  • Added baremetal workflow

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu requested a review from rpastrana January 8, 2024 14:29
rpastrana
rpastrana reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu seems fine, left a few comments/questions

.github/workflows/baremetal-regression-suite.yml Outdated
fetch-depth: 0

- name: Rebase
if: github.event_name == 'pull_request'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does github provide a mechanism to save and re-use jobs? If so, it feels like we should reuse some of these

.github/workflows/baremetal-regression-suite.yml Outdated

branch_name = os.environ['BRANCH_NAME']
latestVersion = getLatestBranchVersion(branch_name)
latestVersionURL = 'https://cdn.hpccsystems.com/releases/CE-Candidate-' + latestVersion + '/bin/platform/hpccsystems-platform-community_' + latestVersion + '-1jammy_amd64_withsymbols.deb'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to communicate this dependency to Clo, just so they know to let us know before they plan to move away from this cdn, etc.

.github/workflows/baremetal-regression-suite.yml Outdated
latestVersion = getLatestBranchVersion(branch_name)
latestVersionURL = 'https://cdn.hpccsystems.com/releases/CE-Candidate-' + latestVersion + '/bin/platform/hpccsystems-platform-community_' + latestVersion + '-1jammy_amd64_withsymbols.deb'

# Return latest version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover commented out code?

@jpmcmu
HPCC4J-553 Github Actions: Add baremetal test workflow
5435a52 
- Renamed existing k8s workflow
- Added baremetal workflow

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu changed the title WIP: HPCC4J-553 Github Actions: Add baremetal test workflow HPCC4J-553 Github Actions: Add baremetal test workflow Jan 9, 2024
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jan 9, 2024

@rpastrana Fixed the git tag issue and addressed code review comments. Please review

rpastrana
rpastrana reviewed Jan 10, 2024
View reviewed changes
.github/workflows/baremetal-regression-suite.yml Outdated
branch_name = os.environ['BRANCH_NAME']

latestVersion = getLatestBranchVersion(branch_name)
previousVersion = [latestVersion[0], latestVersion[1], latestVersion[2] - 2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should report failure if point==0 and cannot be found

rpastrana
rpastrana reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu one comment

@rpastrana rpastrana merged commit deca046 into hpcc-systems:candidate-9.4.x Jan 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana