Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-553 Github Actions: Add baremetal test workflow #674

Merged
merged 1 commit into from
Feb 1, 2024
Merged

HPCC4J-553 Github Actions: Add baremetal test workflow #674

merged 1 commit into from
Feb 1, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jan 30, 2024

  • Fixed issue with decrementing previous version

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu requested a review from rpastrana January 30, 2024 19:27
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jan 30, 2024

@rpastrana please review

rpastrana
rpastrana requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu it seems there's still an issue in the version string:
https://github.com/hpcc-systems/hpcc4j/actions/runs/7712676191/job/21020744098#step:7:1

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jan 31, 2024

@rpastrana This should fix the issue now. Note: it is still targeting master branch to test the fix, will retarget to 9.4.x if tests succeed

@jpmcmu
HPCC4J-553 Github Actions: Add baremetal test workflow
3642254 
- Fixed issue with version being returned as a string for master
- Fixed logic when determining version to test against for master

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu changed the base branch from master to candidate-9.4.x February 1, 2024 13:44
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Feb 1, 2024

@rpastrana Retargeted to 9.4.x, if it looks good it is ready to merge

@jpmcmu jpmcmu changed the base branch from candidate-9.4.x to candidate-9.2.x February 1, 2024 14:56
@jpmcmu jpmcmu changed the base branch from candidate-9.2.x to candidate-9.4.x February 1, 2024 14:56
@rpastrana rpastrana merged commit 9b112b3 into hpcc-systems:candidate-9.4.x Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana