Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCCP4J-571 Github Action: Jirabot Merge fails #677

Merged
merged 1 commit into from
Jan 31, 2024
Merged

HCCP4J-571 Github Action: Jirabot Merge fails #677

merged 1 commit into from
Jan 31, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jan 30, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jan 30, 2024

@rpastrana please review

@jpmcmu jpmcmu requested a review from rpastrana January 30, 2024 20:02
rpastrana
rpastrana reviewed Jan 30, 2024
View reviewed changes
.github/workflows/JirabotMerge.yml
@@ -182,6 +191,11 @@ jobs:
jirabot_user = os.environ['JIRABOT_USERNAME']
jirabot_pass = os.environ['JIRABOT_PASSWORD']
jira_url = os.environ['JIRA_URL']

if not jira_url:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but the hardcoded url will need to be updated soon, and it feels like a workaround rather than a fix (if os.environ['JIRA_URL'] is still not working)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I wanted to get some more debugging information in place, but decided it would be worthwhile to have the backup as well.

rpastrana
rpastrana reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu just one comment/question

@jpmcmu
HPCC4J-571 Github Action: Jirabot Merge fails to find correct tag
4a05ac5 
- Added debugging information for action vars
- Add a default Jira URL as a fallback

Signed-off-by: James McMullan [email protected]
rpastrana
rpastrana approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu

@rpastrana rpastrana merged commit 7253313 into hpcc-systems:candidate-9.4.x Jan 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana