Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-581 WsFS Client should add path delim only if needed #690

Merged
merged 1 commit into from
Mar 7, 2024
Merged

HPCC4J-581 WsFS Client should add path delim only if needed #690

merged 1 commit into from
Mar 7, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Mar 7, 2024 •
edited
Loading

  • Introduces functionality to strip trailing white space
  • Adds trimright utility functionality
  • Adds new test cases
  • Adjusts pre-existing test cases to expected | actual format
  • Do not trim original string parameter
  • Do not duplicate Path URL param

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@rpastrana
HPCC4J-581 WsFS Client should add path delim only if needed
2a6cbc9 
- Introduces functionality to strip trailing white space
- Adds trimright utility functionality
- Adds new test cases
- Adjusts pre-existing test cases to expected | actual format
- Do not trim original string parameter
- Do not duplicate Path URL param

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana requested a review from jpmcmu March 7, 2024 16:44
@rpastrana
Copy link
Member Author

back ported to 9.0.x

@rpastrana
Copy link
Member Author

@jpmcmu please review

jpmcmu
jpmcmu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good

@rpastrana rpastrana merged commit 622b9df into hpcc-systems:candidate-9.0.x Mar 7, 2024
7 checks passed
rpastrana added a commit to rpastrana/HPCC4J that referenced this pull request Mar 8, 2024
@rpastrana
HPCC4J-581 WsFS Client should add path delim only if needed (hpcc-sys…
2a3917d 
…tems#690)

- Introduces functionality to strip trailing white space
- Adds trimright utility functionality
- Adds new test cases
- Adjusts pre-existing test cases to expected | actual format
- Do not trim original string parameter
- Do not duplicate Path URL param

Signed-off-by: Rodrigo Pastrana <[email protected]>
rpastrana added a commit that referenced this pull request Mar 11, 2024
@rpastrana
HPCC4J-581 WsFS Client should add path delim only if needed (#690) (#691
88e5b90 
)

- Introduces functionality to strip trailing white space
- Adds trimright utility functionality
- Adds new test cases
- Adjusts pre-existing test cases to expected | actual format
- Do not trim original string parameter
- Do not duplicate Path URL param

Signed-off-by: Rodrigo Pastrana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu