HPCC4J-577 Added Read Retry to HPCCRemoteFileReader #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-577 Jirabot Action Result: |
drealeed
reviewed
May 2, 2024
| // if (tasks.length > numThreads) | ||
| // { | ||
| // numThreads = tasks.length; | ||
| // } | ||
|
|
dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java
Show resolved
Hide resolved
dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java
Show resolved
Hide resolved
|
@drealeed Thanks for the code review! Implemented code review changes. @rpastrana please review |
rpastrana
reviewed
May 3, 2024
| @@ -425,6 +426,7 @@ private static Options getReadTestOptions() | |||
| options.addOption("user", true, "Specifies the username used to connect. Defaults to null."); | |||
| options.addOption("pass", true, "Specifies the password used to connect. Defaults to null."); | |||
| options.addOption("num_threads", true, "Specifies the number of parallel to use to perform operations."); | |||
| options.addOption("expiry_seconds", true, "Access token expiration seconds."); | |||
| this.recordBuilder = recBuilder; | ||
| if (this.originalRecordDef == null) | ||
| { | ||
| throw new Exception("HpccRemoteFileReader: Original record definition is null."); |
There was a problem hiding this comment.
is there any guidance we can provide to the user in the err message?
| @@ -246,6 +257,51 @@ public HpccRemoteFileReader(DataPartition dp, FieldDef originalRD, IRecordBuilde | |||
| openTimeMs = System.currentTimeMillis(); | |||
| } | |||
|
|
|||
| private boolean retryRead() | |||
| { | |||
| if (retryCount < 3) | |||
There was a problem hiding this comment.
shouldn't the max retry count be configurable?
There was a problem hiding this comment.
@rpastrana Implemented code review changes, will squash if it looks good
rpastrana
approved these changes
May 3, 2024
|
@rpastrana squashed |
- Added Read Retry to HPCCRemoteFileReader - Minor improvements to FileUtility to improve testing Signed-off-by: James McMullan [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: