HPCC4J-650 DFSClient should retain integer subtypes #764
Conversation
|
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-650 Jirabot Action Result: |
|
@rpastrana Note: I am still working on correcting index record definition translation structure. |
| @@ -743,6 +760,10 @@ private static int getJsonTypeDefinition(FieldDef field, HashMap<Integer, Intege | |||
| { | |||
| char delim = 0x0001; | |||
| childJson.put("xpath", childField.getFieldName() + delim + "Row"); | |||
| } else if (childField.getFieldType() == FieldType.SET) | |||
There was a problem hiding this comment.
minor format issue, missing new line
| @@ -743,6 +760,10 @@ private static int getJsonTypeDefinition(FieldDef field, HashMap<Integer, Intege | |||
| { | |||
| char delim = 0x0001; | |||
| childJson.put("xpath", childField.getFieldName() + delim + "Row"); | |||
| } else if (childField.getFieldType() == FieldType.SET) | |||
| { | |||
| char delim = 0x0001; | |||
There was a problem hiding this comment.
it feels like this variable deserves to be a static final with an explicit self documenting name
jpmcmu
changed the title
| * @return true when biased | ||
| * @return true when biased | ||
| * | ||
| * @deprecated |
There was a problem hiding this comment.
let's add a comment indicating which method to use instead of this deprecated method
|
|
||
| int childTypeHash = getJsonTypeDefinition(nonKeyedField, typeDefinitionMap, typeDefinitions); | ||
| int childTypeIndex = typeDefinitionMap.get(childTypeHash); | ||
| String childTypeName = "ty" + (childTypeIndex + 1); |
There was a problem hiding this comment.
it's difficult to rationalize the significance of this literal "ty" let's externalize into a self documenting var
|
@rpastrana Pushed up code review changes, if it looks good will squash |
- Modified record translation code to maintain integer subtype - Fixed record translation test case - Added index record translation to test case Signed-off-by: James McMullan [email protected]
|
Jirabot Action Result: |
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: