Trace: comm_summary and comm_over_time #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hsirkar
commented
Apr 5, 2023
•
hsirkar
commented
- comm_summary computes total message count/volume sent and received per process
- comm_over_time computes total message count/volume sent over time
ocnkr
reviewed
Oct 20, 2023
| comm_matrix = self.comm_matrix(output=output) | ||
|
|
||
| # Get total sent and received for each process | ||
| sent = comm_matrix.sum(axis=1) |
There was a problem hiding this comment.
I recall a recent discussion about sends and receives being on the incorrect axes. Is this line related to that? Are we certain this is correct?
pipit/trace.py
Outdated
| # Filter by send or receive events | ||
| events = self.events[ | ||
| self.events["Name"].isin( | ||
| ["MpiSend", "MpiIsend"] if kind == "send" else ["MpiRecv", "MpiIrecv"] |
There was a problem hiding this comment.
Is the naming always "MpiSend", or can it occasionally be written as "MPISend"? Do we need to handle that?
There was a problem hiding this comment.
I guess it should be the same in all the readers so it shouldn't be a problem.
|
We need to think about why we have an additional "MPISend" event within the "MPI_Send" event and if we can remove it. |
bhatele
approved these changes
Nov 10, 2023
bhatele
force-pushed
the
comm-analysis
branch
from
ea66ae8 to
f2e9228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.