Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to detect ambiguity and likely typos in generaloption #199

Merged
merged 20 commits into from
Oct 10, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 10, 2015

wrapper PR for @stdweird's #185

changes on top include cleanup/enhanced tests and support to also recognise values as likely options (to reject e.g. -rf which is probably meant to be --robot --force but is interpreted as --robot=f

@hpcugentbot
Copy link

One or more tests FAILed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/356/console for more details.

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/357/console for more details.

@boegel
Copy link
Member Author

boegel commented Oct 10, 2015

@stdweird: please review ;)

@boegel
Copy link
Member Author

boegel commented Oct 10, 2015

@stdweird: is this is merged in, #185 will be merged/closed automagically

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/358/console for more details.

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/359/console for more details.

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/360/console for more details.

@boegel boegel merged commit e577869 into hpcugent:master Oct 10, 2015
@boegel
Copy link
Member Author

boegel commented Oct 10, 2015

merged via #185

@boegel boegel deleted the go_nooptionasvalue branch October 10, 2015 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants