Remove creating double slash in url #327
Conversation
lib/vsc/utils/rest.py
Outdated
| @@ -215,6 +215,8 @@ def get_connection(self, method, url, body, headers): | |||
| sep = '/' | |||
| else: | |||
| sep = '' | |||
| if self.url.endswith('/') and url.startswith('/'): | |||
There was a problem hiding this comment.
what url are you trying to parse here?
There was a problem hiding this comment.
@matesaki i'm mainly puzzled why the code above does work.
also add a unittest for this
There was a problem hiding this comment.
Condition above check if there is no slash before merging. If true, add one.
This new condition check if there are to many slashes. If true, remove one.
It may be confusing because there are two variables url, first Ends with '/' and second Starts with '/'.
Trying to make a test ...
There was a problem hiding this comment.
i think the whole code block, incl the previous lines can become
url = url.lstrip('/')
if self.url.endswith('/'):
sep = ''
else:
sep = '/'
There was a problem hiding this comment.
yes, this is equivalent
(rebased)
|
When I running scripts form vsc-ugent.git, then in get_connection() function I got: |
Merging domain url and path url create double slash which causes on localhost error 404 (Page not found). Signed-off-by: Martin Sakin <[email protected]>
Merging domain url and path url creates double slash
which causes on localhost error 404 (Page not found).
Signed-off-by: Martin Sakin [email protected]