Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce S4H PDF upload #444

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Introduce S4H PDF upload #444

wants to merge 11 commits into from

Conversation

jannis-baum
Copy link
Member

@jannis-baum jannis-baum commented Sep 27, 2022

Close #446

Problem

The D4L SDK depends on an older version of tink (1.2, but up to 1.4 in testing) while flutter_secure_storage depends on 1.5. This causes problems, so we use a dummy key until someone figures out what to do

See lib/common/utilities/hive_utils.dart

@github-actions github-actions bot added the P: App Project: App label Sep 27, 2022
@jannis-baum jannis-baum added the T: Feature Type: New Features label Sep 27, 2022
@jannis-baum jannis-baum force-pushed the chdp branch 3 times, most recently from b16be81 to 2da2edc Compare September 27, 2022 07:29
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 72.96% // Head: 70.83% // Decreases project coverage by -2.12% ⚠️

Coverage data is based on head (41fc2a2) compared to base (881bdc4).
Patch coverage: 17.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   72.96%   70.83%   -2.13%     
==========================================
  Files         101      102       +1     
  Lines        2234     2318      +84     
  Branches       95       95              
==========================================
+ Hits         1630     1642      +12     
- Misses        604      676      +72     
Flag Coverage Δ
app 53.81% <17.17%> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/lib/common/models/medication/guideline.dart 11.11% <0.00%> (ø)
app/lib/common/models/medication/medication.dart 4.54% <0.00%> (ø)
app/lib/common/utilities/hive_utils.dart 0.00% <0.00%> (ø)
app/lib/common/utilities/pdf_utils.dart 0.00% <0.00%> (ø)
app/lib/reports/pages/cubit.dart 0.00% <ø> (ø)
app/lib/settings/chdp_state.dart 0.00% <0.00%> (ø)
app/lib/common/pages/medications/medication.dart 56.09% <22.22%> (-39.15%) ⬇️
app/lib/settings/pages/settings.dart 92.72% <87.50%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App Stale T: Feature Type: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add S4H upload button
3 participants