Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit PR for scispacy changes #4

Open
phlobo opened this issue May 6, 2023 · 4 comments
Open

Submit PR for scispacy changes #4

phlobo opened this issue May 6, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@phlobo
Copy link
Member

phlobo commented May 6, 2023

No description provided.

@nachollorca
Copy link
Collaborator

Here is the PR for the language filtering: allenai/scispacy#478

It's just your code with a default value in the .JSON exporter and updating a couple types they changed since you forked it.

@nachollorca
Copy link
Collaborator

And here the same for the custom N-Gram ranges: allenai/scispacy#480

Can you please double check the default I set on the CLI makes sense? I used def main(kb_path: str, output_path: str, n_grams: Tuple[int,int] = (3, 3)): instead of your def main(kb_path: str, output_path: str, n_grams: int):. What do you input in the CLI when you use the --n_grams flag?

@nachollorca
Copy link
Collaborator

Ignore my previous comment, I guess the correct way is:

def main(kb_path: str, output_path: str, n_grams: int):

    ...

    parser.add_argument(
        '--n_grams',
        type=int,
        help="Use n grams to build the index",
        default=(3,3),
    )

@phlobo
Copy link
Member Author

phlobo commented May 16, 2023

PR was merged, we just need to wait for a new release to remove our scispacy patch in /ext

@phlobo phlobo added the good first issue Good for newcomers label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants