Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include our modification of scispacy in ext #9

Merged
merged 11 commits into from
May 16, 2023
Merged

Include our modification of scispacy in ext #9

merged 11 commits into from
May 16, 2023

Conversation

nachollorca
Copy link
Collaborator

@nachollorca nachollorca commented May 13, 2023

Until they merge it to their repo. Maybe we should keep Issue #4 open until they do?

I took care of refactoring all references to the scispacy.umls_utils.py. I checked it building umls dicts with the CLI and it all works fine.

I also updated the dependencies in the .toml and .lock files

I made the function xmen/umls.py:_expand_tuis() public because it is used in other scripts and was crashing the building of the medmentions dict.

@phlobo phlobo merged commit 0af4222 into main May 16, 2023
@phlobo phlobo deleted the scispacy branch May 16, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants