feat: Designer Dashboard Improvements #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
3 times, most recently
from
0270a63 to
960234a
Compare
|
Visit the preview URL for this PR (updated for commit d820e77):
(expires Mon, 24 Jul 2023 17:26:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9506be12830a451dbaab8eda40300701863ad3e |
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
5 times, most recently
from
6dff83c to
b0e5648
Compare
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
from
e6379a3 to
297648e
Compare
github-actions
bot
added
core
dependencies
johannesvedder
changed the title
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
from
543cbe5 to
348d7e2
Compare
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
3 times, most recently
from
6356e4e to
3698a53
Compare
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
from
7b8ef92 to
c59debb
Compare
This was referenced Jul 30, 2023
Closed
…ents # Conflicts: # CONTRIBUTING.md # designer_v2/lib/features/auth/auth_scaffold.dart # docker/README.md # flutter_common/.pubignore # flutter_common/lib/envs/.env.hpi # flutter_common/pubspec.yaml # melos.yaml
|
Visit the preview URL for this PR (updated for commit 595a717):
(expires Wed, 23 Aug 2023 08:10:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b |
jannis-baum
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Looks great! See little comments & some thoughts on UI/UX below
UI/UX (feel free to object!)
- the search bar has this skeuomorphic design that afaik is not used anywhere else in the designer; i would switch to the flat style to make it look more streamlined
- the ability to disable/unclick the sorting to me only makes sense if there is a direct use for the order the studies are shown in in this state. right now it looks like it's just whatever order they have in the database which the user shouldn't have to care about (unless this does have a meaning, then this meaning should be communicated through a clickable field as well). i would do one of
- disable the "don't sort" option by always sorting by something and displaying this accordingly with the arrow (e.g. by default/initially we sort by name descending). clicking one of the fields then just toggles the arrow back and forth and there is no way to completely get rid of it
- give having all arrows disabled the meaning of sorting by a custom order (compare spotify playlists). with this the user should be able to drag & drop to reorder the studies. then the default/initial state can be that no arrows are selected and this custom order is shown. dragging a study when any arrow is disabled (i.e. sorting by anything but the custom order) should not be allowed
designer_v2/lib/features/design/info/study_info_form_controller.dart
Outdated
Show resolved
Hide resolved
|
johannesvedder
force-pushed
the
issue/432-feature-designer-dashboard-improvements
branch
from
48da110 to
595a717
Compare
jannis-baum
approved these changes
Aug 16, 2023
johannesvedder
deleted the
issue/432-feature-designer-dashboard-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #432
More todos moved to issue #494