Some minor refactoring, inspired by SwaLint

hpi-swa-lab · Jul 24, 2021 · a617c9d · a617c9d
1 parent d2b5ac7
commit a617c9d
Show file tree

Hide file tree

Showing 16 changed files with 40 additions and 38 deletions.
diff --git a/packages/SqueakInboxTalk.package/TalkContribution.class/instance/visitBySearcher.context..st b/packages/SqueakInboxTalk.package/TalkContribution.class/instance/visitBySearcher.context..st
@@ -3,4 +3,4 @@ visitBySearcher: aTextSearcher context: context
 
 	self flag: #todo.
 	"Search source code? Would require better caching."
-	aTextSearcher visit: self text: self summary context: context
+	aTextSearcher visit: self contents: self summary context: context
diff --git a/packages/SqueakInboxTalk.package/TalkContribution.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkContribution.class/methodProperties.json
@@ -17,5 +17,5 @@
 		"state" : "ct 5/8/2021 17:23",
 		"summary" : "ct 5/8/2021 17:45",
 		"summaryWithState" : "ct 7/14/2021 23:11",
-		"visitBySearcher:context:" : "ct 7/2/2021 22:46",
+		"visitBySearcher:context:" : "ct 7/24/2021 03:08",
 		"wasAuthoredBy:" : "ct 6/15/2021 14:50" } }
diff --git a/packages/SqueakInboxTalk.package/TalkConversation.class/instance/involvementFor..st b/packages/SqueakInboxTalk.package/TalkConversation.class/instance/involvementFor..st
@@ -1,11 +1,13 @@
 accessing - state
 involvementFor: aPerson
 
+	self flag: #discuss. "Ensure date order - decide about the right place to guarantee this"
+
 	self contributions ifNotEmpty: [:contributions |
-		((contributions first flag: #todo) wasAuthoredBy: aPerson) ifTrue: ["ensure date order"
+		(contributions first wasAuthoredBy: aPerson) ifTrue: [
 		^ #started]].
 
-	((self messages first flag: #todo) wasAuthoredBy: aPerson) ifTrue: ["ensure date order"
+	(self messages first wasAuthoredBy: aPerson) ifTrue: [
 	^ #started].
 	(self messages anySatisfy: [:message | message wasAuthoredBy: aPerson]) ifTrue: [^ #participated].
 	(self includesMentionOf: aPerson) ifTrue: [^ #mentioned].

diff --git a/packages/SqueakInboxTalk.package/TalkConversation.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkConversation.class/methodProperties.json
@@ -14,7 +14,7 @@
 		"includesMentionOf:" : "ct 7/1/2021 13:58",
 		"includesParticipationOf:" : "ct 7/1/2021 13:58",
 		"initialMessage" : "ct 5/7/2021 15:38",
-		"involvementFor:" : "ct 7/21/2021 01:07",
+		"involvementFor:" : "ct 7/24/2021 03:10",
 		"involvementState" : "ct 6/16/2021 16:27",
 		"involvementStateFor:" : "ct 6/15/2021 19:49",
 		"latestDate" : "ct 5/7/2021 15:38",

diff --git a/packages/SqueakInboxTalk.package/TalkFilterSet.class/instance/inbox..st b/packages/SqueakInboxTalk.package/TalkFilterSet.class/instance/inbox..st
@@ -1,4 +1,4 @@
-initialize-release
+accessing
 inbox: anInbox
 
 	self filters do: [:filter | filter inbox: anInbox]
diff --git a/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newDecoratedReply.st b/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newDecoratedReply.st
@@ -1,15 +1,4 @@
 sending messages
 newDecoratedReply
 
-	| receivers ccReceivers bodyString |
-	receivers := ({self inbox mailAddress. self mail replyReceiver}, self mail receivers) withoutDuplicates.
-	ccReceivers := self mail ccReceivers.
-	bodyString := '{1}\\{2}' withCRs asText format: {self inbox decorateMessage: ''. self textQuoted}.
-
-	^ self mail newReply
-		from: MailSender userEmail;
-		to: (receivers joinSeparatedBy: ', ');
-		cc: (ccReceivers joinSeparatedBy: ', ');
-		subject: self replySubject;
-		body: (self inbox newMessageBodyFor: bodyString);
-		yourself
+	^ self newReply: true
diff --git a/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newReply..st b/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newReply..st
@@ -0,0 +1,16 @@
+sending messages
+newReply: decorated
+
+	| receivers ccReceivers bodyString |
+	receivers := {self inbox mailAddress. self mail replyReceiver} withoutDuplicates.
+	ccReceivers := self mail ccReceivers.
+	bodyString := '\\{1}' withCRs format: {self textQuoted}.
+	decorated ifTrue: [bodyString := (self inbox decorateMessage: '') asText, bodyString].
+
+	^ self mail newReply
+		from: MailSender userEmail;
+		to: (receivers joinSeparatedBy: ', ');
+		cc: (ccReceivers joinSeparatedBy: ', ');
+		subject: self replySubject;
+		body: (self inbox newMessageBodyFor: bodyString);
+		yourself
diff --git a/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newReply.st b/packages/SqueakInboxTalk.package/TalkMessage.class/instance/newReply.st
@@ -1,15 +1,4 @@
 sending messages
 newReply
 
-	| receivers ccReceivers bodyString |
-	receivers := {self inbox mailAddress. self mail replyReceiver} withoutDuplicates.
-	ccReceivers := self mail ccReceivers.
-	bodyString := '\\{1}' withCRs format: {self textQuoted}.
-
-	^ self mail newReply
-		from: MailSender userEmail;
-		to: (receivers joinSeparatedBy: ', ');
-		cc: (ccReceivers joinSeparatedBy: ', ');
-		subject: self replySubject;
-		body: (self inbox newMessageBodyFor: bodyString);
-		yourself
+	^ self newReply: false
diff --git a/packages/SqueakInboxTalk.package/TalkMessage.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkMessage.class/methodProperties.json
@@ -14,8 +14,9 @@
 		"mail" : "ct 5/7/2021 15:07",
 		"mail:" : "ct 5/7/2021 15:07",
 		"nabbleUrl" : "ct 7/14/2021 21:03",
-		"newDecoratedReply" : "ct 7/14/2021 18:30",
-		"newReply" : "ct 7/22/2021 15:44",
+		"newDecoratedReply" : "ct 7/24/2021 03:17",
+		"newReply" : "ct 7/24/2021 03:15",
+		"newReply:" : "ct 7/24/2021 03:17",
 		"openInNabble" : "ct 7/22/2021 18:14",
 		"openInPipermail" : "ct 7/22/2021 18:14",
 		"pipermailUrl" : "ct 7/14/2021 21:01",

diff --git a/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/instance/compilePredicate..st b/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/instance/compilePredicate..st
@@ -5,7 +5,7 @@ compilePredicate: aString
 	Internally, the expression will be stored as a CompiledMethod with a #DoItIn: selector generated by the compiler. See also Compiler >> #evaluateCue:ifFail: or InspectorField >> #getValueFor:."
 
 	| compiledMethod |
-	compiledMethod := Compiler new
+	compiledMethod := self compilerClass new
 		compiledMethodFor: aString
 		in: self makeFilterContext
 		to: nil

diff --git a/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/instance/compilerClass.st b/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/instance/compilerClass.st
@@ -0,0 +1,4 @@
+compiling
+compilerClass
+
+	^ Compiler
diff --git a/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkPluggableFilter.class/methodProperties.json
@@ -4,7 +4,8 @@
 	"instance" : {
 		"accepts:" : "ct 7/21/2021 01:56",
 		"argumentNameForConversation" : "ct 7/24/2021 00:29",
-		"compilePredicate:" : "ct 7/24/2021 00:22",
+		"compilePredicate:" : "ct 7/24/2021 03:25",
+		"compilerClass" : "ct 7/24/2021 03:25",
 		"defaultPredicate" : "ct 7/24/2021 00:18",
 		"defaultPredicateString" : "ct 7/13/2021 02:00",
 		"editPredicate" : "ct 7/24/2021 00:27",

diff --git a/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/date.st b/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/date.st
@@ -1,4 +1,4 @@
-accessing
+accessing - messages
 date
 
 	^ self initialMessage date
diff --git a/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/diffText.st b/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/diffText.st
@@ -1,4 +1,4 @@
-accessing
+accessing - messages
 diffText
 
 	self conversations ifNotEmpty: [ | text diffEnd summaryStart |

diff --git a/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/messageText.st b/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/messageText.st
@@ -1,4 +1,4 @@
-accessing
+accessing - messages
 messageText
 
 	self conversations ifNotEmpty: [ | text diffStart summaryEnd |

diff --git a/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/state.st b/packages/SqueakInboxTalk.package/TalkRepositoryContribution.class/instance/state.st
@@ -1,4 +1,4 @@
-accessing
+accessing - contribution
 state
 
 	self repositoryName = #inbox ifTrue: [^ #pending].