Only store custom terminal commands in preference

Storing automatically detected terminal commands causes problems
when knownTerminalCommands is updated, because an old command
may still be stored.

src/FileSystem-Git.package/FileSystemGitRepository.class/instance/detectTerminalCommand.st

@@ -2,7 +2,4 @@ git porcelain - external
 detectTerminalCommand
 	^ self knownTerminalCommands
 		detect: [:each | self commandExists: each]
-		ifNone: [UIManager request:
-					'No terminal emulator could be detected. ',
-					'Please provide a command to spawn a terminal emulator. ',
-					(Preferences pragmaPreferenceFor: GitFeatureFlags getter: #terminalCommandForExternalCommands) helpString]
+		ifNone: [self requestTerminalCommand]

src/FileSystem-Git.package/FileSystemGitRepository.class/instance/requestTerminalCommand.st

@@ -0,0 +1,9 @@
+git porcelain - external
+requestTerminalCommand
+	| command |
+	command := UIManager request:
+		'No terminal emulator could be detected. ',
+		'Please provide a command to spawn a terminal emulator. ',
+		(Preferences pragmaPreferenceFor: GitFeatureFlags getter: #customTerminalCommandForExternalCommands) helpString.
+	GitFeatureFlags customTerminalCommandForExternalCommands: command.
+	^ command

src/FileSystem-Git.package/FileSystemGitRepository.class/instance/terminalCommand.st

@@ -1,13 +1,3 @@
 git porcelain - external
 terminalCommand
-	^ GitFeatureFlags terminalCommandForExternalCommands
-		ifNotEmpty: [:command |
-			(self commandExists: command)
-				ifTrue: [command]
-				ifFalse: [
-					GitFeatureFlags terminalCommandForExternalCommands: ''.
-					self terminalCommand]]
-		ifEmpty: [ | command |
-			command := self detectTerminalCommand.
-			GitFeatureFlags terminalCommandForExternalCommands: command.
-			command]
+	^ GitFeatureFlags customTerminalCommandForExternalCommands ifEmpty: [self detectTerminalCommand]

src/FileSystem-Git.package/FileSystemGitRepository.class/methodProperties.json

@@ -12,7 +12,7 @@
 		"commandExists:" : "mad 4/3/2024 15:10",
 		"commitNamed:" : "jr 8/13/2020 23:08",
 		"createBranchNamed:at:" : "jr 3/4/2020 00:47",
-		"detectTerminalCommand" : "mad 4/3/2024 15:10",
+		"detectTerminalCommand" : "mad 10/31/2024 17:49",
 		"expandRemoteRef:" : "pre 6/15/2018 16:04",
 		"externalCommand:" : "mad 5/22/2024 13:55",
 		"externalGitDo:" : "mad 5/22/2024 13:29",
@@ -46,10 +46,11 @@
 		"remoteUrl:" : "jr 3/4/2020 00:46",
 		"removeRemoteNamed:" : "jr 3/4/2020 00:49",
 		"repository" : "CamilloBruni 6/22/2011 05:08",
+		"requestTerminalCommand" : "mad 10/31/2024 17:50",
 		"tagNamed:" : "MCGitRepositoryTest 3/3/2020 23:40",
 		"tagNames" : "MCGitRepositoryTest 3/3/2020 23:42",
 		"tags" : "jr 3/4/2020 00:49",
-		"terminalCommand" : "mad 12/22/2023 17:34",
+		"terminalCommand" : "mad 10/31/2024 17:51",
 		"terminalCommand:" : "mad 4/3/2024 16:00",
 		"unitOfWork" : "jr 4/10/2020 10:08",
 		"updateBranchNamed:to:" : "jr 3/4/2020 00:50",

src/FileSystem-Git.package/GitFeatureFlags.class/class/customTerminalCommandForExternalCommands..st

@@ -0,0 +1,3 @@
+accessing
+customTerminalCommandForExternalCommands: aString
+	CustomTerminalCommandForExternalCommands := aString

src/FileSystem-Git.package/GitFeatureFlags.class/class/terminalCommandForExternalCommands.st → src/FileSystem-Git.package/GitFeatureFlags.class/class/customTerminalCommandForExternalCommands.st

@@ -1,5 +1,5 @@
 accessing
-terminalCommandForExternalCommands
+customTerminalCommandForExternalCommands
 	<preference: 'Command for spawning a terminal to run external commands' categoryList: #('Git expert settings') description: 'It should contain a pair of curly braces {} where the external command should be inserted. The braces may optionally contain a comma-separated sequence of actions: 1. {quote} quotes the command with single quotes before inserting it, 2. {abc:def} replaces all occurences of abc with def, 3. {no-key} prevents the prompt "Press any key to continue..." from being added after the command. These may be combined, e. g. {quote,":\",quote,sh:zsh}. The actions are executed left-to-right. See FileSystemGitRepository>>knownTerminalCommands for examples.' type: #String>
 
-	^ TerminalCommandForExternalCommands ifNil: ['']
+	^ CustomTerminalCommandForExternalCommands ifNil: ['']

src/FileSystem-Git.package/GitFeatureFlags.class/methodProperties.json

@@ -1,14 +1,14 @@
 {
 	"class" : {
+		"customTerminalCommandForExternalCommands" : "mad 10/31/2024 17:50",
+		"customTerminalCommandForExternalCommands:" : "mad 10/31/2024 17:50",
 		"evictFromObjectCache" : "jr 8/10/2020 23:42",
 		"evictFromObjectCache:" : "jr 4/20/2020 21:59",
 		"evictFromObjectCacheForTests:" : "jr 4/20/2020 23:33",
 		"externalFetchAndPush" : "tobe 10/15/2022 07:17",
 		"externalFetchAndPush:" : "tobe 10/15/2022 07:17",
 		"pruneWhenFetching" : "mad 4/7/2024 18:31",
 		"pruneWhenFetching:" : "mad 4/7/2024 14:46",
-		"terminalCommandForExternalCommands" : "mad 4/3/2024 16:37",
-		"terminalCommandForExternalCommands:" : "mad 12/20/2023 18:04",
 		"warnAboutUseOfDeprecatedMethods" : "jr 9/21/2020 23:10",
 		"warnAboutUseOfDeprecatedMethods:" : "jr 4/17/2020 11:49" },
 	"instance" : {

src/FileSystem-Git.package/GitFeatureFlags.class/properties.json

@@ -3,10 +3,10 @@
 	"classinstvars" : [
 		 ],
 	"classvars" : [
+		"CustomTerminalCommandForExternalCommands",
 		"EvictFromObjectCache",
 		"ExternalFetchAndPush",
 		"PruneWhenFetching",
-		"TerminalCommandForExternalCommands",
 		"UseUnitOfWorkInterface",
 		"WarnAboutUseOfDeprecatedMethods" ],
 	"commentStamp" : "",