Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186 scraping room fix #280

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

186 scraping room fix #280

wants to merge 2 commits into from

Conversation

leanmas
Copy link
Contributor

@leanmas leanmas commented Feb 15, 2022

Remove database constraint of rooms having to have a floor linked.
Scraping now might create new room objects (created only if a room with the same full_name doesn't exist yet) that have no floor and no building linked and are thus not visible on the map, but people now have the new scraped room objects linked. Also those new room objects link to all the people that are located in that room.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #280 (023ae1e) into dev (84d1f73) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #280      +/-   ##
==========================================
+ Coverage   78.93%   79.12%   +0.18%     
==========================================
  Files          52       52              
  Lines        1054     1054              
==========================================
+ Hits          832      834       +2     
+ Misses        222      220       -2     
Impacted Files Coverage Δ
app/models/room.rb 100.00% <100.00%> (ø)
lib/scraping/scraper.rb 95.83% <100.00%> (ø)
lib/scraping/problem_checker.rb 89.74% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d1f73...023ae1e. Read the comment docs.

@leanmas leanmas assigned kpostnov and unassigned kpostnov Feb 17, 2022
@leanmas leanmas requested a review from kpostnov February 17, 2022 14:00
Copy link
Contributor

@kpostnov kpostnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether there is still time for this, but the tests are red in this one.
Furthermore, I couldn't check what happens when you click "Show on map" on rooms that have no building / floors linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants