146 navigation webapp #147
Conversation
|
Woah, looks awesome! I don't think we should show two footers at the same page, this would be very unintuitive. Another hint: Could you use bootstrap-select for the status choice? It's an extenal library but quite simple to use and would look much more better than the current plain HTML solution IMHO. What do you think? :) |
This is indeed unintuitive, but the whole dashboard has to be redesigned anyway. Right now there is just an example text. I'll ask if someone is already doing this and ask them if they could integrate my solution to their dashboard. The ticket just said it wanted to have a header and a footer, so I guess it editing the dashboard would be out of scope
AFIK I don't use a select dropdown menu in this design because it wasn't in the scoop adding a status choice or anything, so there's no need for bootstrap select. Or what do you mean? |
# Conflicts: # app/assets/stylesheets/mobile.scss # app/views/layouts/_navbar.html.erb # spec/features/navbar_spec.rb
Because the dashboard will be redesigned anyway, we leave it as-is for the moment. |
|
@rheaSPK The ubuntu image is still in the repository. Apart from this, looks perfect now :-) |
|
@rheaSPK Thank you for your effort! I think the navigation can still be improved.
|
|
@frcroth Interesting ideas, could you create a new issue for them? |
|
OK #160 |
Closes #146
Since the dashboard page has it's own footer and doesn't provide independent routes for chatting and dashboard, the current dashboard page looks like this:
Note, that chat and dashboard have the exact same routes, that's why the footer shows both be clicked. I expect that the dashboard will be redesigned eventually, that's why I don't see an issue with that right now.
Also there is no real settings page, I've put
edit_user_pathfor the current user instead. If there's a settings page eventually, this has to be replaced.Since we have no history page at all, this link isn't linking anywhere.