Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Nested Attachments (Issue #13) #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dzastera
Copy link

Updated attachment processing to handle nested attachments and updated the regex on msg_fields to be more robust with grep.

Nested attachments contain the string "__attach_version1.0" more than once, which was not handled uniquely with grep resulting in all nested attachment information being written out when saving, rather than just the attachment information.

This fix addresses the uniqueness issue by using more of the key to keep the attachments distinct. The regex on the 'msg_fields' items have been modified to include the terminal 4 hex digits in each value. The addition of an end-of-line anchor helps assure that the msg_fields are not matched mid-key - an issue with nested attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant