Fix for Nested Attachments (Issue #13) #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated attachment processing to handle nested attachments and updated the regex on msg_fields to be more robust with grep.
Nested attachments contain the string "__attach_version1.0" more than once, which was not handled uniquely with grep resulting in all nested attachment information being written out when saving, rather than just the attachment information.
This fix addresses the uniqueness issue by using more of the key to keep the attachments distinct. The regex on the 'msg_fields' items have been modified to include the terminal 4 hex digits in each value. The addition of an end-of-line anchor helps assure that the msg_fields are not matched mid-key - an issue with nested attachments.