Correct logging for "recursive" syscalls #19893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
the
Code Cleanup
Merged
hrydgard
force-pushed
the
syscall-log-recursion
branch
from
a2d436b to
0d21d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a convenient way to automatically log parameters of HLE syscalls. Unfortunately it breaks down when one syscall calls another.
This fixes that by introducing "hleCall()", and imposing some new rules. To make this work, i've had to fix a LOT of logging inconsistencies and cleaned things up.
Long term this is probably worth it for more accurate logs.
Also unbreaks Tekken 6 which I accidentally broke recently.(edit: fixed separately in #19895 )