Infrastructure: Don't connect to adhoc unless infra-dns.json tells us to #19897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we should enable it from json only, since only a few games needed it. |
…uping is set in the json
hrydgard
force-pushed
the
dont-connect-to-adhoc
branch
from
935d4b8 to
51b6519
Compare
|
Added the other two relevant games to the json and rebased. Will test a little bit and then merge. Nice with cleaner logs, hehe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need your opinion @anr2me !
In my (limited) testing, forcibly connecting to adhoc for grouping just isn't necessary. But I haven't tested all games yet.
Maybe should add a manual setting?