Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: fix exception handle for delete topic and read latency tracking #1720

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

YangKian
Copy link
Contributor

PR Description

Type of change

  • Bug fix

Summary of the change and which issue is fixed

Main changes:

  • fix incorrect errorCode:
    If two clients, a and b, perform the following operations concurrently: listTopic >>= deleteTopic, then in the delete handler, even if S.doesStreamExist returns true, the subsequent deletion may still throw a NOTFOUND exception. In this case, this exception would be incorrectly mapped to UNKNOWN_SERVER_ERROR, rather than UNKNOWN_TOPIC_OR_PARTITION.
  • fix read latency tracking for consume handler

Checklist

  • I have run format.sh under script
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@YangKian YangKian requested a review from 4eUeP December 27, 2023 06:34
@4eUeP 4eUeP merged commit 9131db5 into hstreamdb:main Dec 27, 2023
10 checks passed
@YangKian YangKian deleted the delete branch December 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants