Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1071 #1259

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

dutkalex
Copy link
Contributor

No description provided.

@JohelEGP
Copy link
Contributor

JohelEGP commented Oct 4, 2024

The simplest change, and still a good improvement over the status-quo,
it just requiring a member initializer,
suggesting = () as one typically does to comply with @basic_value.

@hsutter
Copy link
Owner

hsutter commented Oct 31, 2024

Hi! Just checking in as I clean up the PRs with the relicensing (see #1322), is still intended to be still a draft PR? If so perhaps I'll close it for now and you can reopen this or a new PR once it's ready to look at?

As described in #1322, this didn't make release 0.8, so I will need a new one-time CLA that will cover all your future contributions. I've emailed you the new CLA, and one it's completed I can look at PRs.

@dutkalex
Copy link
Contributor Author

dutkalex commented Nov 2, 2024

Hi! This PR is in standby on my side, until I can get my day job to stop invading my weekends 😅

I've emailed you the new CLA, and one it's completed I can look at PRs.

I think I missed your email @hsutter, and I can't seem to find it

@dutkalex
Copy link
Contributor Author

dutkalex commented Nov 2, 2024

If so perhaps I'll close it for now and you can reopen this or a new PR once it's ready to look at?

No problem to close the PR if you wish to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants