Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [...nextauth].ts #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DedicatedManagers
Copy link

Not sure which branch to try to merge this to... mostly just doing this to get your attention and offer some help.

I'm suggesting this change because I want to participate, but don't want to grant WRITE access to my profile and account as your app is requesting.

I didn't test this, but I think this would lower the scopes to read-only.

You may need more permissions, but this is a start. Technically, from my knowledge (which is limited), to use this for "authentication" as you seem to be using it for, you would need the "openid" scope, but github doesn't seem to support that scope.

Per: https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/
read:user Grants access to read a user's profile data.
user:email Grants read access to a user's email addresses.

I'm suggesting this change because I want to participate, but don't want to grant WRITE access to my profile and account as your app is requesting.

I didn't test this, but I think this would lower the scopes to read-only.  

You may need more permissions, but this is a start.  Technically, from my knowledge (which is limited), to use this for "authentication" as you seem to be using it for, you would need the "openid" scope, but github doesn't seem to support that scope.  


Per: https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/
read:user	Grants access to read a user's profile data.
user:email  Grants read access to a user's email addresses.
@vercel
Copy link

vercel bot commented Nov 25, 2020

@DedicatedManagers is attempting to deploy a commit to a Personal Account owned by @hswolff on Vercel.

@hswolff first needs to authorize it.

@DedicatedManagers
Copy link
Author

Woops... I didn't know that would actually try to merge it. I thought it would just create a request for you to look at.

@vercel
Copy link

vercel bot commented Jan 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hswolff/votey-uppy/12cagte82
✅ Preview: https://votey-uppy-git-fork-dedicatedmanagers-patch-1.hswolff.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant