Allow selling items to an shop. Checked full inventories. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, I'll review this, test it, and merge 👍 |
| public static final Key<Value<Boolean>> IS_SPONGY_CHEST = KeyFactory.makeSingleKey(Boolean.class, Value.class, DataQuery.of("IsSpongyChest")); | ||
| public static final Key<Value<UUID>> UUID_CHEST = KeyFactory.makeSingleKey(UUID.class, Value.class, DataQuery.of("UUIDChest")); | ||
| public static final Key<Value<ItemStackSnapshot>> ITEM_CHEST = KeyFactory.makeSingleKey(ItemStackSnapshot.class, Value.class, DataQuery.of("ItemChest")); | ||
| public static final Key<Value<Double>> PRICE_CHEST = KeyFactory.makeSingleKey(Double.class, Value.class, DataQuery.of("PriceChest")); | ||
| public static final Key<ListValue<Double>> PRICES_CHEST = KeyFactory.makeListKey(Double.class, DataQuery.of("PricesChest")); |
There was a problem hiding this comment.
This change will break all previous SpongyChest shops.
|
@Zartec Looking over this it seems like you made it so all shops are both |
|
This is possible over: If the sell price is |
|
Reverted the dataquery key to the previous |
Zartec
force-pushed
the
feature/AllowSelling
branch
from
70250e7 to
52ed976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows players to create shops on which items can be sold and bought.
Also shops which only sells or only buys are possible.
Also the inventories of the chest and the player are checked for free space, because sponge inserts the items to the armor slots if there is no more space.
Left click sells items if you are not the owner and you don`t have the destroy permission
The command is changed to:
[] -> required<> -> optional/spongychest setshop [sellprice] <[buyprice]>/spongychest setshop <-s sellprice> <-b buyprice>/spongychest setshop <--sell-price=sellprice> <--buy-price=buyprice>