Merge pull request #66 from htcondor/yqu/no_crash_for_fail_jobad

Update parse_job_ad() and add TestParseJobAd()
htcondor · May 23, 2023 · 36c093d · 36c093d
2 parents 634752b + 9f51127
commit 36c093d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/main.go b/main.go
@@ -494,7 +494,7 @@ func parse_job_ad(payload payloadStruct) { // TODO: needs the payload
 
 	b, err := os.ReadFile(filename)
 	if err != nil {
-		log.Fatal(err)
+		log.Warningln("Can not read .job.ad file", err)
 	}
 
 	// Get all matches from file

diff --git a/main_test.go b/main_test.go
@@ -200,3 +200,13 @@ func FuzzGetTokenName(f *testing.F) {
 		assert.Equal(t, strings.ToLower(orig), tokenName, "URL: "+urlString+"URL String: "+url.String()+" Scheme: "+url.Scheme)
 	})
 }
+
+func TestParseNoJobAd(t *testing.T) {
+	// Job ad file does not exist
+	tempDir := t.TempDir()
+	path := filepath.Join(tempDir, ".job.ad")
+	os.Setenv("_CONDOR_JOB_AD", path)
+
+	payload := payloadStruct{}
+	parse_job_ad(payload)
+}