HTCONDOR-1731 Try replacing dots in token names with underscores #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djw8605 this is my first time writing in Go, so please be as harsh as possible on my code style and whatnot 🙂 |
jasoncpatton
force-pushed
the
HTCONDOR-1731-dots-to-underscore
branch
3 times, most recently
from
37b4293 to
cd1b54b
Compare
While adding support for underscores in URL schemes was laudible, there is still a problem parsing the (illegal) URLs upstream in HTCondor. Until we come up with a permanent solution, our workaround is to have users submit with a "." in place of the "_" (similar to how the client handles underscores internally) and have any plugins do the conversion from "." to "_" when doing token discovery. Here I have refactored the HTCondor-specific token discovery code into its own function, which will search for both tokens with and without "." replaced with "_" in their filenames. The TestGetToken test was expanded to test URL schemes using both "_" and "." and token files named with both "_" and ".".
jasoncpatton
force-pushed
the
HTCONDOR-1731-dots-to-underscore
branch
from
cd1b54b to
8930b9b
Compare
|
@jhiemstrawisc reassigning review to you (same applies, any Go feedback welcome!) |
jhiemstrawisc
requested changes
Oct 9, 2023
Done for the |
jhiemstrawisc
added a commit
to jhiemstrawisc/pelican
that referenced
this pull request
Oct 9, 2023
This PR brings a PR from OSDF-Client to Pelican that handles parsing token names with `.`s in their name. For more information, see: htcondor/osdf-client#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for https://opensciencegrid.atlassian.net/browse/HTCONDOR-1731
While adding support for underscores in URL schemes was laudable, there is still a problem parsing the (illegal) URLs upstream in HTCondor. Until we come up with a permanent solution, our workaround is to have users submit with a
.in place of the_(similar to how the client handles underscores internally) and have any plugins do the conversion from.to_when doing token discovery.I have refactored the HTCondor-specific token discovery code into its own function, which will search for both tokens with and without
.replaced with_in their filenames. TheTestGetTokentest was expanded to test URL schemes using both_and.and token files named with both_and..