Remove content length from put to enable chunked #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the content length from a put changes the upload style from full file upload to a chunked encoded upload. A full file upload causes go to read in the entire file in memory while uploading, chunked does not.
djw8605
added a commit
to djw8605/pelican
that referenced
this pull request
Oct 10, 2023
Removing the content length from a put changes the upload style from full file upload to a chunked encoded upload. A full file upload causes go to read in the entire file in memory while uploading, chunked does not. **NOTE** chunked uploads only work after xrootd has merged and put into production xrootd/xrootd#2102 Corresponds to htcondor/osdf-client#88
|
What will happen when this talks to a server that doesn't have the #2102 fix? Is there any backward compat work that needs to be done to talk to older servers? |
|
Possibly, also being discussed over on PelicanPlatform/pelican#208 Can add a check on server version, though, that would take another request to the server. I feel like there are no great options. |
bbockelm
pushed a commit
to djw8605/pelican
that referenced
this pull request
Dec 1, 2023
Removing the content length from a put changes the upload style from full file upload to a chunked encoded upload. A full file upload causes go to read in the entire file in memory while uploading, chunked does not. **NOTE** chunked uploads only work after xrootd has merged and put into production xrootd/xrootd#2102 Corresponds to htcondor/osdf-client#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the content length from a put changes the upload style from full file upload to a chunked encoded upload. A full file upload causes go to read in the entire file in memory while uploading, chunked does not.
NOTE chunked uploads only work after xrootd has merged and put into production xrootd/xrootd#2102