Fix for virtual-destructor error? #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breznak
commented
Feb 22, 2019
| @@ -105,7 +105,8 @@ class SDR_MetricsHelper_ { | |||
| * streaming data. This class deals with finding a suitable weight for each | |||
| * sample. | |||
| */ | |||
| virtual void callback( SDR &dataSource, Real alpha ) = 0; | |||
| virtual void callback( SDR &dataSource, Real alpha ) | |||
| { NTA_THROW << "Virtual method 'SDR_MetricsHelper_.callback' called!"; } | |||
There was a problem hiding this comment.
I thinks the original was valid C++ code, so unless we find no other way, I'd prefer not to merge this.
There was a problem hiding this comment.
Yea I don't really understand underlying issue and don't want to merge until I do. I wonder it has something to do with the compiler version?
@pepedocs is using
-- CMAKE_CXX_COMPILER_ID= AppleClang
-- CMAKE_CXX_COMPILER_VERSION=10.0.0.10001044
Our CI is using:
-- CMAKE_CXX_COMPILER_ID= AppleClang
-- CMAKE_CXX_COMPILER_VERSION=9.0.0.9000038
There was a problem hiding this comment.
PR #220 bumps our CI to the latest OSX (10), so let's get that PR to merge and we can replicate this issue.
|
replaced by #276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #274