-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumped versions of dependencies #978
Conversation
This PR addresses Issue #975 |
Should we bump the versions on the Python dependencies as well? |
I don't think we need to bump the python dependencies because IIRC "setup.py" will automatically install the latest version. |
ok, that is why I asked. It's just that requirements.txt specifies a version. I don't know if that just specifies a minimum or locks it to that version. |
This pickle problem is not going to be easy to find. I thought we had something to do that but it has been so long ago and my 75 year-old brain is not recalling it. |
Ok, I just checked it. Yes, our "requirements.txt" only specifies minimums. The python test cases will display anything printed to std-out when they fail, its part of the test summary that's printed at the end. The place where the error is generated, I assume that this bug is the result of updating the cereal library? |
backing out cereal had no effect. I will push this and you can take a look at it. |
That's my fault. I think I introduced those errors when I backed out a change to the anomaly likelihood code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retested this (linux, release mode) and it all passes except for the 2 failing anomaly likelihood tests. This all looks good to me!
Ok, the changes to the dependency versions is now in master. |
First cut at bumping the versions of all dependencies