Suggestion for Enhancing select
Consistency with Popper.js Integration
#521
+20
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @olegpix,
This is a suggestive pull request.
In the new example for
select
where users can use"dropdownScope": "window"
, they currently need to explicitly include Popper.js on their page. However, this step is unnecessary fordropdown
andtooltip
, as they already utilize Popper.js internally.To ensure consistency across components and improve user experience, I propose integrating Popper.js with
select
internally, just likedropdown
andtooltip
. This change will eliminate the need for users to include Popper.js separately on their pages.Before Changes
When Popper.js is not included in the page:
After Changes
With updates to
select/index.ts
, Popper.js is used internally without requiring explicit inclusion:I believe this change improves consistency and simplifies implementation for users.
Thank you!