-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --spa option #772
base: master
Are you sure you want to change the base?
Add --spa option #772
Conversation
Allows serving of SPAs * with correct status code 200 * without using the defekt `Catch-all redirect` fixes issue http-party#757
SPA support has been discussed numerous times over the years. See especially #369 (comment), but there's further discussion in #369, #405 and #194 (there are a few others, but they didn't add much to the discussion). Although this PR is small, I'm concerned that adding an Does this PR add anything other than an approach to solving #757? |
Thank you @thornjad for linking the related issues :) My motivation was solving the trouble related to #757. I don't insist in this pull request to be the chosen solution. All options I commented would be fine for me. My reasoning for implementing an I would argue, the amount of attempts to implement such an option show, that already a minimal solution would be very appreciated. Unfortunately the inked alternatives are all unmaintained. You wrote:
Could you elaborate what other functionality for serving an SPA might be requested? |
I personally do not care what this function is called. If it's called |
There is another major advantage of using the solution from this pull request, compared to the |
+1 could greatly use an SPA-functionality. Need http-server as opposed to 'serve' because http-server supports Range Requests in bytes, which are needed for loading a static sqlite3 db on-demand using wa-sqlite. |
Allows serving of SPAs
Catch-all redirect
Relevant issues
fixes issue #757
Contributor checklist
--help
outputmaster
branchMaintainer checklist