Skip to content

Conversation

@KernelDeimos
Copy link
Contributor

This PR updates #901 so that it adds the flag --websocket to the implementation that was already merged

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@KernelDeimos
Copy link
Contributor Author

Going to merge. One test failed but this occurred because of an EADDRINUSE exception which is known to happen due to race conditions in the unit tests when they try to spin up testing servers.

This was thought to be fixed by ensuring ephemeral ports are always used. It's likely there are still some places where this was missed.

@KernelDeimos KernelDeimos merged commit f6306d5 into master Nov 4, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants