Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding options.host to defaultHosts list #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasterOdin
Copy link
Contributor

PR fixes a bug reported in #120 (comment), where the current indexOf check will only succeed if options.host was already in exports._defaultHosts, as opposed to the desired behavior of appending it if it's not in the array.

I've also cleaned up the nested conditional to just be one level as the nesting was not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant