Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the parameter names to ensure there are no duplicates after parsing a route #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check the parameter names to ensure there are no duplicates after parsing a route #39

wants to merge 3 commits into from

Commits on Aug 21, 2019

  1. Add a test after parsing a route to ensure it doesn't contain duplica… 

    …te parameter names
    Gameldar committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    215a805 View commit details
    Browse the repository at this point in the history

  2. Change add to return a Result to indicate failures when parsing the r… 

    …oute
    Gameldar committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    5843a16 View commit details
    Browse the repository at this point in the history

  3. Split the implementation to add and add_check 

    add calls add_check and unwraps it

Also added a bit of documentation around the router and the add methods
    Gameldar committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    fa0f7d6 View commit details
    Browse the repository at this point in the history