Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: readds transfer encoding to the header list. #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcchavezs
Copy link
Collaborator

Transfer-Encoding property turns into a request field by the http handler, this commit adds it back for the sake of correctness.

Still trying to figure out how to write the test.

Transfer-Encoding property turns into a request field by the http handler, this commit adds it back for the sake of correctness.
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for unit test, maybe something like Test_host_GetProtocolVersion but GetRequestHeaderValues. Then in the test make it a table-driven test which has a field req *http.Request and in that you can set the special Host and TransferEncoding.

TCK would be good insulation as well, even though even if TCK is updated, the above unit test should be there. testRunner.testGetHeaderValuesRequest is awkward to do host/trasnfer encoding, so there after the table test, you could make separate calls like r.t.Run("host", func(t *testing.T) { with explicit impls which probably need to construct the http client requests.

@codefromthecrypt
Copy link
Contributor

I will try to land the intended change this week, in this PR or another

@codefromthecrypt
Copy link
Contributor

closing as I don't have time to polish this and stale PRs don't tend to proceed. Someone can finish this including tests in another PR if they choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants