dhall-haskell → dhallj #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eliminating the |
|
This PR should now be ready. I updated the PR description. |
amesgen
commented
Apr 21, 2020
| @@ -24,7 +24,7 @@ let steps = | |||
| c.Run::{ | |||
| , name = "Test docs" | |||
| , run = "docs/makeSite" | |||
| , if = Some "startsWith(matrix.scala, '2.12')" | |||
| , `if` = Some "startsWith(matrix.scala, '2.12')" | |||
There was a problem hiding this comment.
These backticks are necessary as the previous version was only accepted due to a bug in dhall-haskell.
|
Ah, release.yml still has one issue, " is escaped to ". |
|
Ok, this is in fact a dhallj issue, I will report it (see travisbrown/dhallj#56). I personally don't think it is worth to temporarily revert this PR, as this does not seem like a major issue. |
|
Sorry about these escaping issues—the YAML export clearly needs some attention and tests, which I should be able to get to in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dhallj, we no longer depend on dhall-haskell and its binaries, in order to only depend on a JVM.
Twoone minor downside:The generated YAML has ugly multi-line strings, and I think that is a limitation of SnakeYAML (see here).This is a known issue in dhallj, will probably be fixed soon.Fixed in dhallj 0.2.0.Just run
convertDhallfor updating the YAML files.